Change in vdsm[master]: Adding system information to getCapabilities

danken at redhat.com danken at redhat.com
Thu Nov 22 16:32:40 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Adding system information to getCapabilities
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/caps.py
Line 264: 
Line 265:     cpuInfo = CpuInfo()
Line 266:     cpuTopology = CpuTopology()
Line 267: 
Line 268:     caps['hostManufacturer'] = __getDmidecodeData("system-manufacturer")
executing dmidecode 6 times feels excessive.
Line 269:     caps['hostProductName'] = __getDmidecodeData("system-product-name")
Line 270:     caps['hostVersion'] = __getDmidecodeData("system-version")
Line 271:     caps['hostSerialNumber'] = __getDmidecodeData("system-serial-number")
Line 272:     caps['hostUUID'] = __getDmidecodeData("system-uuid")


....................................................
File vdsm/constants.py.in
Line 147: EXT_VDSM_STORE_NET_CONFIG = '@VDSMDIR@/vdsm-store-net-config'
Line 148: 
Line 149: EXT_WGET = '@WGET_PATH@'
Line 150: EXT_WRITE_NET_CONFIG = '@VDSMDIR@/write-net-config'
Line 151: EXT_DMIDECODE = '@DMIDECODE_PATH@'
why have you ditched python-dmidecode?
we would like to clean constants.py, not add more to it.
Line 152: 
Line 153: CMD_LOWPRIO = [EXT_NICE, '-n', '19', EXT_IONICE, '-c', '3']
Line 154: 
Line 155: #


--
To view, visit http://gerrit.ovirt.org/9258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list