Change in vdsm[master]: Fix block volume atomicity creation issue.

ewarszaw at redhat.com ewarszaw at redhat.com
Wed Nov 21 17:22:53 UTC 2012


Eduardo has posted comments on this change.

Change subject: Fix block volume atomicity creation issue.
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/storage/blockVolume.py
Line 640: 
Line 641: def _getVolumeTag(sdUUID, volUUID, tagPrefix):
Line 642:     tags = lvm.getLV(sdUUID, volUUID).tags
Line 643:     if TAG_VOL_UNINIT in tags:
Line 644:         log.warning("Reloading unfinished volume %s/%s", sdUUID, volUUID)
This situation is changing the rules for the hsm system including the design of the lvm cache.
Until we work only with volulmes in the hsm, is meaning that engine is stressing too much the cluster.
We don't expect too many entries of this log. If they are is better to know it and think again the whole issue.
IMHO should be harmless, not clutter the log too much and useful for debugging.
Line 645:         lvm.invalidateVG(sdUUID)
Line 646:         tags = lvm.getLV(sdUUID, volUUID).tags
Line 647:         if TAG_VOL_UNINIT in tags:
Line 648:             log.error("Unfinished volume %s/%s", sdUUID, volUUID)


Line 644:         log.warning("Reloading unfinished volume %s/%s", sdUUID, volUUID)
Line 645:         lvm.invalidateVG(sdUUID)
Line 646:         tags = lvm.getLV(sdUUID, volUUID).tags
Line 647:         if TAG_VOL_UNINIT in tags:
Line 648:             log.error("Unfinished volume %s/%s", sdUUID, volUUID)
Done
Line 649:             raise se.VolumeDoesNotExist("%s/%s" % (sdUUID, volUUID))
Line 650: 
Line 651:     for tag in tags:
Line 652:         if tag.startswith(tagPrefix):


--
To view, visit http://gerrit.ovirt.org/9358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40cd67e563935de663d938cbc1bc9cf152802448
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list