Change in vdsm[master]: Adding system information to getCapabilities
ybronhei at redhat.com
ybronhei at redhat.com
Wed Nov 21 16:18:42 UTC 2012
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding system information to getCapabilities
......................................................................
Patch Set 2: (2 inline comments)
....................................................
Commit Message
Line 8:
Line 9: Using dmidecode to get system info and return it by getCaps api
Line 10:
Line 11: Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0
Line 12: Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=867543
what do you mean? only some comments can be private. we always put the bug-id
....................................................
File vdsm/caps.py
Line 248:
Line 249:
Line 250: def __getDmidecodeData(whatdata):
Line 251: # dmidecode commands must run as root (sude=True)
Line 252: ret, out, err = execCmd([constants.EXT_DMIDECODE, '-s', whatdata], True)
ye... we don't really need this module. It requests root permissions anyways, and its output is too complex. I prefer to use dmidecode command to get only the relevant information (we don't need to much anyway)
Line 253: if err:
Line 254: raise OSError("Error while collecting system info: %s", err)
Line 255: return out[0]
Line 256:
--
To view, visit http://gerrit.ovirt.org/9258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list