Change in vdsm[master]: configNet: support PREFIX option

asegurap at redhat.com asegurap at redhat.com
Wed Nov 21 10:16:10 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: configNet: support PREFIX option
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 892: 
Line 893:     if mtu:
Line 894:         mtu = int(mtu)
Line 895: 
Line 896:     prefix = int(options.get('prefix'))
I was checking the fedora docs for ifcfg-* files and I don't see a mention to 'PREFIX'. However, checking /etc/sysconfig/network-scripts/ifup-aliases I can see it there as the alternative to NETMASK. Thus, I was wrong in accepting this change, since as I understand, deployUtils.py.in will get prefix in caps via _getBridgeParams and pass it in caps to addNetwork, making it necessary to do options.get('PREFIX') as well as options.get('prefix').
Line 897:     if prefix:
Line 898:         if netmask is None:
Line 899:             netmask = _prefix2netmask(prefix)
Line 900:             del options['prefix']


--
To view, visit http://gerrit.ovirt.org/9322
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d87818642aa2092533f4864728c5ecd5d64f740
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list