Change in vdsm[master]: vdsm-tool: add the sebool configuration module

danken at redhat.com danken at redhat.com
Tue Nov 20 14:51:00 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-tool: add the sebool configuration module
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

minor naming suggestion.

....................................................
File vdsm-tool/seboolsetup.py
Line 51:     sebool_obj.finish()
Line 52: 
Line 53: 
Line 54: @expose("sebool-enable")
Line 55: def sebool_enable():
this name assume that we would never need to disable any seboolean.

how about keeping it a bit more general, like "selinux-config" or "selinux-unconfig".
Line 56:     """Enable the required selinux booleans"""
Line 57:     setup_booleans(True)
Line 58: 
Line 59: 


--
To view, visit http://gerrit.ovirt.org/9362
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01baf1c17f7cad2a0525b261be6b5ac648576252
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list