Change in vdsm[master]: split config file for HSM service standalone
shuming at linux.vnet.ibm.com
shuming at linux.vnet.ibm.com
Tue Nov 20 08:43:28 UTC 2012
Shu Ming has posted comments on this change.
Change subject: split config file for HSM service standalone
......................................................................
Patch Set 1: (4 inline comments)
In general, "config" and "hsmconfig" were used in these files as object name. It is reasonable to unify these two names into one for clean style.
....................................................
File vdsm/libvirtvm.py
Line 2270: #'allocation' will give the qcow2 image size
Line 2271: #D. Berrange
Line 2272: capacity, alloc, physical = self._dom.blockInfo(d.path, 0)
Line 2273: if (physical >
Line 2274: (alloc + config.getint(
It looks like the config here should be replaced by hsmconfig
Line 2275: 'irs', 'volume_utilization_chunk_mb'))):
Line 2276: self.log.warn('%s = %s/%s error %s phys: %s alloc: %s '
Line 2277: 'Ingnoring already managed event.',
Line 2278: blockDevAlias, d.domainID, d.volumeID,
....................................................
File vdsm/storage/Makefile.am
Line 72: nodist_hsmpylib_PYTHON = \
Line 73: config.py
Line 74:
Line 75: nodist_noinst_DATA = \
Line 76: hsm.conf.sample
nodist_hsmpylib_DATA?
Line 77:
Line 78: CLEANFILES = \
Line 79: $(nodist_noinst_DATA) \
Line 80: $(nodist_hsmpylib_PYTHON)
Line 75: nodist_noinst_DATA = \
Line 76: hsm.conf.sample
Line 77:
Line 78: CLEANFILES = \
Line 79: $(nodist_noinst_DATA) \
nodist_hsmpylib_DATA?
Line 80: $(nodist_hsmpylib_PYTHON)
Line 81:
Line 82: EXTRA_DIST = \
Line 83: 12-vdsm-lvm.rules \
Line 86: hsm.conf.sample: Makefile config.py
Line 87: @echo " CONFIG $@"; $(PYTHON) $(builddir)/config.py > $@
Line 88:
Line 89: all-local: \
Line 90: $(nodist_noinst_DATA) \
nodist_hsmpylib_DATA?
Line 91: $(nodist_hsmpylib_PYTHON)
Line 92:
Line 93: check-local:
--
To view, visit http://gerrit.ovirt.org/9345
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f62a4108275a1295f122025973a767f79b75780
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list