Change in vdsm[master]: PEP 8: fix "E302 expected 2 blank lines" in tests/apiTests.p...

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Tue Nov 20 03:46:43 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: PEP 8: fix "E302 expected 2 blank lines" in tests/apiTests.py
......................................................................


Patch Set 1: Verified; Looks good to me, but someone else must approve

Pass autobuild.sh on my machine.

Jenkins unit test failure is not related to this patch. You can see from its console output at
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/80/console .
Jenkins checkouts the commit 2c0fd0796ad to build which is origin/master, but not f97cbfe0aecf which is this patch. So it builds on the old code and triggers a PEP 8 violation that's exactly to be fixed in this patch.

--
To view, visit http://gerrit.ovirt.org/9346
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27608d7d00c7d8e72a043eba387cd4e9f03fa837
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list