Change in vdsm[master]: Nit fixes of supervdsmServer

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Mon Nov 19 15:00:32 UTC 2012


Shu Ming has posted comments on this change.

Change subject: Nit fixes of supervdsmServer
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/supervdsmServer.py
Line 372:             servThread.join()
Line 373:         finally:
Line 374:             if os.path.exists(address):
Line 375:                 utils.rmFile(address)
Line 376:                 raise RuntimeError('supervdsmServer exited')
The supervdsmServer process and the module supervdsm.py should belong to two different process.  So the exceptions threw out by supervdsmServer is meaningless to vdsm process including supervdsm.py module.  I agree to remove the raise here.
Line 377: 
Line 378:     except Exception:
Line 379:         log.error("Could not start Super Vdsm", exc_info=True)
Line 380:         sys.exit(1)


--
To view, visit http://gerrit.ovirt.org/9316
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie87c2332ca6342044e0c157231ea8c076ad622cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list