Change in vdsm[master]: Handle spaces in device names using lvm filter

ykaplan at redhat.com ykaplan at redhat.com
Mon Nov 19 12:22:13 UTC 2012


Yeela Kaplan has posted comments on this change.

Change subject: Handle spaces in device names using lvm filter
......................................................................


Patch Set 3: (2 inline comments)

....................................................
Commit Message
Line 6: 
Line 7: Handle spaces in device names using lvm filter
Line 8: 
Line 9: Change-Id: I1efb6dfd30c0999f14c413fff778213b247a178f
Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=819745
Sorry it was the wrong url,
I have updated the bug-url in next patch...


....................................................
File vdsm/storage/lvm.py
Line 133:     devs = []
Line 134:     for dev in devList:
Line 135:         if dev.strip():
Line 136:             devs.append(dev.strip().encode("string_escape").
Line 137:                                     replace(' ', r'\\\\x20'))
Due to filter rules by lvm in order to recognize a device name with a space (a space in the device name is encoded in hexa to '\x20') we need the filter to be with: '\\\\x20'.
Line 138:     filt = '|'.join(devs)
Line 139:     if len(filt) > 0:
Line 140:         filt = "'a%" + filt + "%', "
Line 141: 


--
To view, visit http://gerrit.ovirt.org/9191
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1efb6dfd30c0999f14c413fff778213b247a178f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list