Change in vdsm[master]: spec: Add MOM as a package dependency

danken at redhat.com danken at redhat.com
Sun Nov 18 19:22:41 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: spec: Add MOM as a package dependency
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm.spec.in
Line 119: Requires: genisoimage
Line 120: Requires: libselinux-python
Line 121: Requires: %{name}-python = %{version}-%{release}
Line 122: Requires: pyparted
Line 123: Requires: mom <= 0.3.0
do you expect mom-0.3.1 to break API? "less than" requires are not very common, and usually hide a nasty story that I'd like to know about...
Line 124: 
Line 125: Requires(pre,preun): policycoreutils-python
Line 126: Requires(post): /usr/sbin/saslpasswd2
Line 127: Requires(post): /bin/hostname


--
To view, visit http://gerrit.ovirt.org/9272
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e8c5a67066f270b8f19881ac5871ff844dbecaa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list