Change in vdsm[master]: Alert if vdsm log has wrong user\group permissions

danken at redhat.com danken at redhat.com
Sun Nov 18 19:16:06 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Alert if vdsm log has wrong user\group permissions
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vdsmd.init.in
Line 101:         /sbin/restorecon "$run_path"
Line 102:     done
Line 103: }
Line 104: 
Line 105: verify_log_permissions() {
Please consider again replacing this function's implementation with

 su vdsm > /dev/null 2>&1 << EOF
 echo >> @VDSMLOGDIR@/vdsm.log
 EOF
Line 106:     VDSM_USER=`id -u vdsm`
Line 107:     VDSM_GROUP=`id -g vdsm`
Line 108:     LOG_OWNER=`stat -c "%u" @VDSMLOGDIR@/vdsm.log`
Line 109:     LOG_GROUP=`stat -c "%g" @VDSMLOGDIR@/vdsm.log`


--
To view, visit http://gerrit.ovirt.org/9118
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bd379803b01627d6897992ee8798c6a22195b0f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list