Change in vdsm[master]: Add qemu's memory usage to VM statistics.

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Fri Nov 16 08:59:14 UTC 2012


ShaoHe Feng has posted comments on this change.

Change subject: Add qemu's memory usage to VM statistics.
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 177:             with open('/proc/%d/status' % (self.conf['pid'])) as f:
Line 178:                 for line in f:
Line 179:                     var, value = line.strip().split()[0:2]
Line 180:                     if var in ('VmSize:', 'VmRSS:', 'VmData:'):
Line 181:                         memUsage[var[:-1]] = long(value)
I have tried to get these values from /proc/%d/status.
 and find the unit symbol is “KB”
 Is it necessary to explicit the unit symbol?
Line 182:         return memUsage
Line 183: 
Line 184:     def _diff(self, prev, curr, val):
Line 185:         return prev[val] - curr[val]


--
To view, visit http://gerrit.ovirt.org/9006
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeb35759454c4a9b41e1303956267e93ca3545a0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list