Change in vdsm[master]: storage.misc: subclass DeferableContext for easy undoing

smizrahi at redhat.com smizrahi at redhat.com
Thu Nov 15 15:58:28 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: storage.misc: subclass DeferableContext for easy undoing
......................................................................


Patch Set 6: I would prefer that you didn't submit this

Looks like the only difference between the two class is whether to use the first or last exception.
I personally don't care.

Also I like the name of you class better

Just change DeferableContext() to whatever you need with the name you want.

--
To view, visit http://gerrit.ovirt.org/8671
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc932637dd81c3becf92de34ea647c1cea136111
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list