Change in vdsm[master]: Logging: config logging in new process of remoteFileHandler
shaohef at linux.vnet.ibm.com
shaohef at linux.vnet.ibm.com
Thu Nov 15 10:31:28 UTC 2012
ShaoHe Feng has posted comments on this change.
Change subject: Logging: config logging in new process of remoteFileHandler
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
as you mentioned, add a comment.
....................................................
File vdsm/storage/remoteFileHandler.py
Line 376: if __name__ == "__main__":
Line 377: try:
Line 378: from logging import config as lconfig
Line 379: loggerConfFile = constants.P_VDSM_CONF + 'logger.conf'
Line 380: lconfig.fileConfig(loggerConfFile, disable_existing_loggers=False)
have check other code of vdsm that call fileConfig, they do not disable disable_existing_loggers.
here is different, so a comment is welcome. I make me more easy to get the reason.
Line 381:
Line 382: try:
Line 383: myRead, myWrite = parseArgs()
Line 384: closeFDs((myRead, myWrite, 2))
--
To view, visit http://gerrit.ovirt.org/9182
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b3b9e2837d632c7532fcd8f7306ed50b0865b5c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list