Change in vdsm[master]: Adding support for force extend block domains

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Wed Nov 14 15:48:24 UTC 2012


Shu Ming has posted comments on this change.

Change subject: Adding support for force extend block domains
......................................................................


Patch Set 5:

I really don't understand why we need the force flag here.  It seems _initpvs() try to reinitialize the physical volume already in a volume group with new meta size.  Is it meaningful to reinitialize a physical volume which is based on a physical device.  And you can never extend a physical device because its size is hard limitted.  Adding some comments to explain these may be helpful.

--
To view, visit http://gerrit.ovirt.org/9192
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33ad4ee65d7303705d2cc8370502553125000ca0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list