Change in vdsm[master]: Implement SSL session cache

danken at redhat.com danken at redhat.com
Tue Nov 13 21:11:56 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Implement SSL session cache
......................................................................


Patch Set 11: Looks good to me, approved

(1 inline comment)

so let's take this!

....................................................
File tests/sslTests.py
Line 124: 
Line 125:         # Stop the server thread and wait for it to finish:
Line 126:         self.thread.shutdown()
Line 127:         self.thread.join()
Line 128:         del self.thread
I must say that these del's make me raise an eyebrow.
Line 129: 
Line 130:         # Close the server socket:
Line 131:         self.server.shutdown(socket.SHUT_RDWR)
Line 132:         self.server.close()


--
To view, visit http://gerrit.ovirt.org/8123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic75adee4070b415b8855af1f2ea289825496fbc1
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list