Change in vdsm[master]: remoteFileHandler: improve PYTHONPATH definition

danken at redhat.com danken at redhat.com
Tue Nov 13 10:55:19 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: remoteFileHandler: improve PYTHONPATH definition
......................................................................


remoteFileHandler: improve PYTHONPATH definition

The recently added import for logUtils in misc.py broke the out of
process (remoteFileHandler) subsystem (ImportError: No module named
logUtils).
Defining PYTHONPATH with relative paths is both unreliable and
insecure.

In this patch:
* Remove an old sys.path modification in misc.py
* Improve the PYTHONPATH definition in remoteFileHandler removing the
  relative path

Change-Id: I29dd748bcc9658a98ad86313921bfd94c96b83a6
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
---
M vdsm/storage/misc.py
M vdsm/storage/remoteFileHandler.py
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Zhou Zheng Sheng: Verified; Looks good to me, but someone else must approve

Objections:
  Shu Ming: I would prefer that you didn't submit this


--
To view, visit http://gerrit.ovirt.org/9193
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I29dd748bcc9658a98ad86313921bfd94c96b83a6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list