Change in vdsm[master]: Adding support for force extend block domains

abaron at redhat.com abaron at redhat.com
Tue Nov 13 07:03:26 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: Adding support for force extend block domains
......................................................................


Patch Set 1: (4 inline comments)

....................................................
File vdsm/storage/blockSD.py
Line 675:                         self._metadata[key] = mapping[key]
Line 676:                     else:
Line 677:                         del self._metadata[key]
Line 678: 
Line 679:     def extend(self, devlist, force=False):
no need to define default here.
Line 680:         mapping = self.readMetadataMapping().values()
Line 681:         if self.getVersion() in VERS_METADATA_LV:
Line 682:             if len(mapping) + len(devlist) > MAX_PVS:
Line 683:                 raise se.StorageDomainIsMadeFromTooManyPVs()


....................................................
File vdsm/storage/lvm.py
Line 900:     if vg:
Line 901:         removeVG(vg.name)
Line 902: 
Line 903: 
Line 904: def extendVG(vgName, devices, force=False):
no need for default here
Line 905:     pvs = [_fqpvname(pdev) for pdev in _normalizeargs(devices)]
Line 906:     _checkpvsblksize(pvs, getVGBlockSizes(vgName))
Line 907:     vg = _lvminfo.getVg(vgName)
Line 908:     #Format extension PVs as all the other already in the VG


....................................................
File vdsm/storage/sd.py
Line 741: 
Line 742:     def refresh(self):
Line 743:         pass
Line 744: 
Line 745:     def extend(self, devlist, force=False):
no need for default here
Line 746:         pass
Line 747: 
Line 748:     def isMaster(self):
Line 749:         return self.getMetaParam(DMDK_ROLE).capitalize() == MASTER_DOMAIN


....................................................
File vdsm/storage/sp.py
Line 2077:     def validateVolumeChain(self, sdUUID, imgUUID):
Line 2078:         repoPath = os.path.join(self.storage_repository, self.spUUID)
Line 2079:         image.Image(repoPath).validateVolumeChain(sdUUID, imgUUID)
Line 2080: 
Line 2081:     def extendSD(self, sdUUID, devlist, force=False):
no need for default here
Line 2082:         sdCache.produce(sdUUID).extend(devlist, force)


--
To view, visit http://gerrit.ovirt.org/9192
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33ad4ee65d7303705d2cc8370502553125000ca0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list