Change in vdsm[master]: Logging: config logging in new process of remoteFileHandler

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Tue Nov 13 04:16:27 UTC 2012


Shu Ming has posted comments on this change.

Change subject: Logging: config logging in new process of remoteFileHandler
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/remoteFileHandler.py
Line 36: 
Line 37: if __name__ == "__main__":
Line 38:     from logging import config as lconfig
Line 39:     loggerConfFile = constants.P_VDSM_CONF + 'logger.conf'
Line 40:     lconfig.fileConfig(loggerConfFile)
I am wondering if remoteFileHandler.py is imported by other file.  Then the logging facility will not function in these pieces. It may depend on the logging facility from the upper layer modules.
Line 41: 
Line 42: import misc
Line 43: import fileUtils
Line 44: 


--
To view, visit http://gerrit.ovirt.org/9182
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b3b9e2837d632c7532fcd8f7306ed50b0865b5c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list