Change in vdsm[master]: Sending sigkill to verify svdsm suicide

danken at redhat.com danken at redhat.com
Mon Nov 12 22:09:47 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Sending sigkill to verify svdsm suicide
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/supervdsmServer.py
Line 292:         while True:
Line 293:             os.kill(parentPid, 0)
Line 294:             sleep(2)
Line 295:     except Exception:
Line 296:         if os.path.exists(ADDRESS):
I suppose that this might be raceful.
Line 297:             os.unlink(ADDRESS)
Line 298:         os.kill(os.getpid(), signal.SIGKILL)
Line 299: 
Line 300: 


--
To view, visit http://gerrit.ovirt.org/9196
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2eb8f1a74f818cd10a08572c9adb5de1c0e21f5a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list