Change in vdsm[master]: Handle spaces in device names using lvm filter
ewarszaw at redhat.com
ewarszaw at redhat.com
Mon Nov 12 21:23:34 UTC 2012
Eduardo has posted comments on this change.
Change subject: Handle spaces in device names using lvm filter
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/lvm.py
Line 132: devList.sort()
Line 133: devs = []
Line 134: for dev in devList:
Line 135: if dev.strip():
Line 136: devs.append('\\\\\\\\x20'.join(dev.strip().
Can we use a raw string to avoid the '\' plague?
Line 137: encode("string_escape").split()))
Line 138: filt = '|'.join(devs)
Line 139: if len(filt) > 0:
Line 140: filt = "'a%" + filt + "%', "
--
To view, visit http://gerrit.ovirt.org/9191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1efb6dfd30c0999f14c413fff778213b247a178f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
More information about the vdsm-patches
mailing list