Change in vdsm[master]: Handle a race where it takes some time fot the cmdline to di...

smizrahi at redhat.com smizrahi at redhat.com
Mon Nov 12 18:33:26 UTC 2012


Saggi Mizrahi has uploaded a new change for review.

Change subject: Handle a race where it takes some time fot the cmdline to disappear after killing a process
......................................................................

Handle a race where it takes some time fot the cmdline to disappear after killing a process

Change-Id: I2d7a8190bb3b8e2251309b91f341a00f89618be5
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
---
M tests/miscTests.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/9204/1

diff --git a/tests/miscTests.py b/tests/miscTests.py
index 6d6b234..964fc74 100644
--- a/tests/miscTests.py
+++ b/tests/miscTests.py
@@ -24,6 +24,7 @@
 import threading
 from testrunner import VdsmTestCase as TestCaseBase
 import inspect
+from vdsm import utils
 
 import storage.outOfProcess as oop
 import storage.misc as misc
@@ -86,7 +87,9 @@
         sproc = misc.execCmd(args, sync=False, sudo=False)
         sproc.kill()
         try:
-            self.assertEquals(misc.getCmdArgs(sproc.pid), tuple())
+            test = lambda: self.assertEquals(misc.getCmdArgs(sproc.pid),
+                                             tuple())
+            utils.retry(AssertionError, test, tries=10, sleep=0.1)
         finally:
             sproc.wait()
 


--
To view, visit http://gerrit.ovirt.org/9204
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d7a8190bb3b8e2251309b91f341a00f89618be5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list