Change in vdsm[master]: storage: set block schedule elevator using udev

juan.hernandez at redhat.com juan.hernandez at redhat.com
Fri Nov 9 16:04:32 UTC 2012


Juan Hernandez has posted comments on this change.

Change subject: storage: set block schedule elevator using udev
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

I think this is a good step forward. I would suggest to add a comment to the vdsm-elevator.sh script explaining the current limitations (modifies all devices, modifies dm devices, etc) so we can remember later to improve it.

....................................................
File vdsm/storage/vdsm-elevator.sh
Line 3: elevator="$1"
Line 4: scheduler="/sys/${DEVPATH}/queue/scheduler"
Line 5: 
Line 6: if [ -w "${scheduler}" ]; then
Line 7:     echo "${elevator}" >  "${scheduler}"
Why the extra space after > ?


--
To view, visit http://gerrit.ovirt.org/8700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list