Change in vdsm[master]: make vdsm/storage/hsm.py PEP8 clean

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Thu Nov 8 02:51:54 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: make vdsm/storage/hsm.py PEP8 clean
......................................................................


Patch Set 10: Verified

I update my pep8 tool to 1.3.3, it now checks indentation of continued lines. Although we suppress the those errors in make check, I take some time to fix those problems in hsm.py. I hope it might help.

Pass autobuild.sh. Verify with pydiff, it finds 3 changes.

 pydiff hsm*.py
 3 difference(s)
 first file: hsmo.py
 second file: hsm.py

((1324, 'Cannot delete shared image%s. volImgs: %s'),
 (1425, 'Cannot delete shared image %s. volImgs: %s'))

 ((1792, '=='), (1918, 'is'))

((1793,
  "Compare(CallFunc(Name('type'), [Name('force')], None, None), [('==', CallFunc(Name('type'), [Const('')], None, None))])"),
 (1918,
  "CallFunc(Name('isinstance'), [Name('force'), Name('str')], None, None)"))

In fact in the original file, a string in line 1324 is wrapped incorrectly, it missed a space. This is corrected in this patch. The first difference report item is about that.

The other two changes are acceptable as well, the reason is in previous code review comments.

--
To view, visit http://gerrit.ovirt.org/4530
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9b2f8b9e83db6f52678b4e0865668a79bcf53f5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list