Change in vdsm[master]: avoid creating hangover in storage domain cache after format...

vfeenstr at redhat.com vfeenstr at redhat.com
Wed Nov 7 08:44:31 UTC 2012


Vinzenz Feenstra has posted comments on this change.

Change subject: avoid creating hangover in storage domain cache after formatting
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 2294:             try:
Line 2295:                 sdCache.manuallyRemoveDomain(sdUUID)
Line 2296:             except KeyError:
Line 2297:                 self.log.warn("Storage domain %s doesn't exist in cache. "
Line 2298:                               "Trying recycle leftovers ...", sdUUID)
This log message implies that there would be done something afterwards, but this is no longer the case.
Please adjust the log message. Thank you.
Line 2299: 
Line 2300: 
Line 2301:     @public
Line 2302:     def formatStorageDomain(self, sdUUID, autoDetach = False, options = None):


--
To view, visit http://gerrit.ovirt.org/8144
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie13a97ad6830553cbd099189dfb82d6f02ce82fe
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list