Change in vdsm[master]: Adding threads limitation to misc.tmap

ybronhei at redhat.com ybronhei at redhat.com
Wed Nov 7 08:02:19 UTC 2012


Yaniv Bronhaim has posted comments on this change.

Change subject: Adding threads limitation to misc.tmap
......................................................................


Patch Set 8:

This changes the return value of itmap, with your suggestion itmap returns (index,val). I'm not sure if we want this kind of change.. only fileSD calls to itmap and I can modify it if this change sounds right. But then the use in itmap will look weird (itmap(...).next()[1] :/)

Do you think it helps? or just redundant because nobody calls to tmap?
As part of infra team, I'm not sure if to keep unused functions just to have more infrastructure is the right thing to do. In my opinion, I prefer to remove tmap because of its useless.

If you initiate multiply threads with same implementation, you don't really care about the order..

--
To view, visit http://gerrit.ovirt.org/8858
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07845bfd78b9215e8994ac2ebe46a7ff78c85625
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list