Change in vdsm[master]: storage: set block schedule elevator using udev

danken at redhat.com danken at redhat.com
Tue Nov 6 21:05:16 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: storage: set block schedule elevator using udev
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

I thought that it's a bit messy to run vdsm-elevator multiple times on non-vdsm devices - it would be nicer to call our script on out devices only.

I'm not advocating the use of kernel command line, I'm saying that it had a planned use case that your suggested solution make a bit harder.

(and I'm not completely sure that this is Ayal's biggest concern, let him speak up)

--
To view, visit http://gerrit.ovirt.org/8700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list