Change in vdsm[master]: storage: set block schedule elevator using udev

abaron at redhat.com abaron at redhat.com
Tue Nov 6 10:29:26 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: storage: set block schedule elevator using udev
......................................................................


Patch Set 1:

I know that we've discussed this, but reviewing the patch (which looks fine by the way) I still think the right solution is to change the default scheduler in boot parameter.

It easily allows user to:
1. change default scheduler
2. target specific devices and change the scheduler.
Both of the above would not require the user to know about vdsm specific udev rules.

In addition, the current rule targets all block devices in the system and if users already have code that changes the scheduler for some devices, this would override it and they might not even be aware of the change (but suffer from a performance hit).

--
To view, visit http://gerrit.ovirt.org/8700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list