Change in vdsm[master]: Add callback to the plethora of retry halting possibilities

abaron at redhat.com abaron at redhat.com
Mon Nov 5 22:03:53 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: Add callback to the plethora of retry halting possibilities
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File tests/miscTests.py
Line 641:                                "Then quit. There's no point in being a damn"
Line 642:                                "fool about it.")
Line 643:                                # W. C. Fields
Line 644: 
Line 645:         self.assertRaises(RuntimeError, misc.retry, foo, tries=(limit - 1), sleep=0,
this raises because you've hit the max number of retries, not because stopCallback returned true.
Line 646:                          stopCallback=stopCallback)
Line 647: 
Line 648:         counter[0] = 0
Line 649:         misc.retry(foo, RuntimeError, tries=limit, sleep=0,


--
To view, visit http://gerrit.ovirt.org/8093
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb5a2158f008b41133352dcfb4926ad21dcceea1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>


More information about the vdsm-patches mailing list