Change in vdsm[master]: BZ#836161 - Rewrite of deleteImage().

abaron at redhat.com abaron at redhat.com
Mon Nov 5 21:25:21 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#836161 - Rewrite of deleteImage().
......................................................................


Patch Set 12: (1 inline comment)

....................................................
File vdsm/storage/blockSD.py
Line 206:     try:
Line 207:         lvm.changelv(sdUUID, volUUIDs, (("-a", "y"), ("--deltag", imgUUID),
Line 208:                             ("--addtag", sd.REMOVED_IMAGE_PREFIX + imgUUID)))
Line 209:     except se.StorageException as e:
Line 210:         log.debug("SD %s, Image %s pre zeroing ops failed", sdUUID, imgUUID,
you say pre-zeroing failed but you go on as if it didn't?
Line 211:                     volUUIDs)
Line 212:     # Following call to changelv is separate since setting rw permission on an
Line 213:     # LV fails if the LV is already set to the same value, hence we would not
Line 214:     # be able to differentiate between a real failure of deltag/addtag and one


--
To view, visit http://gerrit.ovirt.org/8506
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list