Change in vdsm[master]: BZ#836161 - Rewrite of deleteImage().

danken at redhat.com danken at redhat.com
Mon Nov 5 21:15:00 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#836161 - Rewrite of deleteImage().
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File vdsm/storage/blockSD.py
Line 186:     size = multipath.getDeviceSize(dm) # Bytes
Line 187:     # TODO: Change for zero 128 M chuncks and log.
Line 188:     # 128 M is the vdsm extent size default
Line 189:     BS = constants.MEGAB # 1024 ** 2 = 1 MiB
Line 190:     count = size / BS
correcting myself: BS is 1MiB, but it is still an integer factor of our chunk size (128MiB) so this division would always be exact.
Line 191:     cmd = tuple(constants.CMD_LOWPRIO)
Line 192:     cmd += (constants.EXT_DD, "iflag=%s" % misc.DIRECTFLAG, "if=/dev/zero",
Line 193:                     "of=%s" % os.path.join("/dev", sdUUID, volUUID),
Line 194:                     "bs=%s" % BS, "count=%s" % count)


--
To view, visit http://gerrit.ovirt.org/8506
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list