Change in vdsm[master]: BZ#836161 - Rewrite of deleteImage().

danken at redhat.com danken at redhat.com
Mon Nov 5 20:23:28 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#836161 - Rewrite of deleteImage().
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File vdsm/storage/blockSD.py
Line 913:                         if i.startswith(blockVolume.TAG_PREFIX_IMAGE) ]
Line 914:         return images
Line 915: 
Line 916:     def deleteImage(self, sdUUID, imgUUID, volsImgs):
Line 917:         return deleteVolumes(sdUUID, volsImgs)
Eduardo is an adamant warrior against virtual functions in Python. No chance he'd agree to that...
Line 918: 
Line 919:     def zeroImage(self, sdUUID, imgUUID, volsImgs):
Line 920:         return zeroImgVolumes(sdUUID, imgUUID, volsImgs)
Line 921: 


--
To view, visit http://gerrit.ovirt.org/8506
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list