Change in vdsm[master]: BZ#855924 -- fix 3.1 -> 3.0 migration again

danken at redhat.com danken at redhat.com
Mon Nov 5 18:27:17 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#855924 -- fix 3.1 -> 3.0 migration again
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

I should have thought of that :-(.

How come this got verified earlier? May I ask for an independent verification this time?

....................................................
File vdsm/vm.py
Line 255:             self.status['progress'] = 10
Line 256:             MigrationSourceThread._ongoingMigrations.acquire()
Line 257:             try:
Line 258:                 self.log.debug("migration semaphore acquired")
Line 259:                 # patch VM config for targets < 3.1
oops. Seems that this should be tucked inside _setupRemoteMachineParams()
Line 260:                 self._patchConfigForLegacy()
Line 261:                 if not mstate:
Line 262:                     self._vm.conf['_migrationParams'] = {
Line 263:                         'dst': self._dst,


--
To view, visit http://gerrit.ovirt.org/9036
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I334cd39cad3eed30c2c3f1efa7085526454a44fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>


More information about the vdsm-patches mailing list