Change in vdsm[master]: Fix getCmdArgs() on some hosts

danken at redhat.com danken at redhat.com
Mon Nov 5 18:08:46 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Fix getCmdArgs() on some hosts
......................................................................


Patch Set 12: Looks good to me, but someone else must approve

(1 inline comment)

can someone hunt down this kernel bug? we have a good reproducer.

....................................................
File vdsm/storage/misc.py
Line 1076: 
Line 1077: def getCmdArgs(pid):
Line 1078:     res = tuple()
Line 1079:     # Sometimes cmdline is empty even though the process is not a zombie.
Line 1080:     # Retrying seems to solve it.
isn't this a kernel bug? should I remind you what someone told me about the implementation of vdsm.utils.readIfaceStat() ?
Line 1081:     while len(res) == 0:
Line 1082:         # cmdline is empty for zombie processes
Line 1083:         if pidStat(pid)[2] in ("Z", "z"):
Line 1084:             return tuple()


--
To view, visit http://gerrit.ovirt.org/9039
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id74dcc975d48ba6d7ee18c7f4154523f08e64245
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list