Change in vdsm[master]: BZ#836161 - Rewrite of deleteImage().

abaron at redhat.com abaron at redhat.com
Mon Nov 5 15:03:13 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#836161 - Rewrite of deleteImage().
......................................................................


Patch Set 8: (1 inline comment)

....................................................
Commit Message
Line 6: 
Line 7: BZ#836161 - Rewrite of deleteImage().
Line 8: 
Line 9: Volume operations should be done at the SD level to avoid
Line 10: retrieving static data multiple times from disk.
Can you check again to see if you can access the bug? It looks public to me and I see no reason for it not to be available.
Line 11: Added lvm.lvPhysDev() returning the dm-X for active LVs.
Line 12: Use this to get active LV size without issue a lvm command.
Line 13: 
Line 14: Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695


--
To view, visit http://gerrit.ovirt.org/8506
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list