Change in vdsm[master]: schema: New type VmParameters

danken at redhat.com danken at redhat.com
Sun Nov 4 20:53:05 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: schema: New type VmParameters
......................................................................


Patch Set 7: (1 inline comment)

....................................................
Commit Message
Line 7: schema: New type VmParameters
Line 8: 
Line 9: Although the format of the data passed via VM.create is very similar to a
Line 10: VmDefinition, some of the parameters don't make sense to pass in the context of
Line 11: creating a new VM.  Solve this by creating a new type for VM parameters.
Yes, I think that VmCreateParameters/VmProperties are indeed clearer.

(why isn't Saggi reviewing these base patches?)
Line 12: 
Line 13: Change-Id: I00d1b9aed55cbfc2210c1a4091bce17d45b90e67


--
To view, visit http://gerrit.ovirt.org/7839
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d1b9aed55cbfc2210c1a4091bce17d45b90e67
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list