Change in vdsm[master]: Another missing of joinAll after using ThreadPool
ybronhei at redhat.com
ybronhei at redhat.com
Sun Nov 4 13:39:19 UTC 2012
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Another missing of joinAll after using ThreadPool
......................................................................
Another missing of joinAll after using ThreadPool
ThreadPool initiates threads during its construct. The threads are
cleaned only by calling joinAll function.
This patch adds this call after using HSM_MailMonitor's threadPool.
Otherwise, the threads will stay alive until vdsm process will be
killed, and this was a leak.
Change-Id: I207d8db5863e11e89394b9144600b625282c51b6
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/storage/storage_mailbox.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/9009/1
diff --git a/vdsm/storage/storage_mailbox.py b/vdsm/storage/storage_mailbox.py
index c537883..f6f5337 100644
--- a/vdsm/storage/storage_mailbox.py
+++ b/vdsm/storage/storage_mailbox.py
@@ -446,7 +446,7 @@
self.log.info("HSM_MailboxMonitor - Incoming mail monitoring thread stopped, clearing outgoing mail")
self._outgoingMail = EMPTYMAILBOX
self._sendMail() # Clear outgoing mailbox
-
+ self.tp.joinAll(waitForTasks=False)
class SPM_MailMonitor:
--
To view, visit http://gerrit.ovirt.org/9009
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I207d8db5863e11e89394b9144600b625282c51b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
More information about the vdsm-patches
mailing list