Change in vdsm[master]: fileVolume: make getVSize a real classmethod

abaron at redhat.com abaron at redhat.com
Sun Nov 4 09:51:14 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: fileVolume: make getVSize a real classmethod
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/fileVolume.py
Line 460: 
Line 461:     @classmethod
Line 462:     def getVSize(cls, sdobj, imgUUID, volUUID, bs=512):
Line 463:         imagePath = image.Image(sdobj._getRepoPath()).getImageDir(
Line 464:                                                     sdobj.sdUUID, imgUUID)
Yaniv, this is __init__ in image.py:
    def __init__(self, repoPath):
        self.repoPath = repoPath
        self.storage_repository = config.get('irs', 'repository')

Which paths are you referring to exactly?
Line 465:         volPath = os.path.join(imagePath, volUUID)
Line 466:         return int(sdobj.oop.os.stat(volPath).st_size / bs)
Line 467: 
Line 468:     @classmethod


--
To view, visit http://gerrit.ovirt.org/8995
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I336d4e763da4ddc3c0dd8eacb68e84305995e6ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list