Change in vdsm[master]: Change in error message format

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Sat Nov 3 15:11:58 UTC 2012


ShaoHe Feng has posted comments on this change.

Change subject: Change in error message format
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

But I still think when raise Exception, either err or out should not be None.

....................................................
File vdsm/gluster/exception.py
Line 56:         s = self.message
Line 57:         if m:
Line 58:             s += '\nerror: ' + m
Line 59:         if self.rc:
Line 60:             s += '\nreturn code: %s' % self.rc
yes,  the follow message may be confused to user.
 'error: 
 return code: 0'

 But I still think when raise Exception, either err or out should not be None. if no error, why raise Exception?
 git grep -E "raise.*Gluster.*Exception"
 all the instances of inherited class use "err".
Line 61: 
Line 62:         return s
Line 63: 
Line 64:     def response(self):


--
To view, visit http://gerrit.ovirt.org/8689
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb948bb212ae866600aabad2190ff52f2cbc05bf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>


More information about the vdsm-patches mailing list