Change in vdsm[master]: Don't forget to close thread pool when stopping the SPM mail...

danken at redhat.com danken at redhat.com
Fri Nov 2 20:05:52 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Don't forget to close thread pool when stopping the SPM mailer
......................................................................


Patch Set 4: (2 inline comments)

....................................................
Commit Message
Line 3: AuthorDate: 2012-11-01 13:25:07 -0400
Line 4: Commit:     Saggi Mizrahi <smizrahi at redhat.com>
Line 5: CommitDate: 2012-11-01 17:28:04 -0400
Line 6: 
Line 7: Don't forget to close thread pool when stopping the SPM mailer
why not explain what forgetting this does to vdsm?
Line 8: 
Line 9: Change-Id: I0fd696a20254380e0a0067dd33c7709445e38afb


....................................................
File tests/storageMailboxTests.py
Line 43:             with open(os.path.join(self.__masterDir, fname), "w") as f:
Line 44:                 f.write("DATA")
Line 45: 
Line 46:     def __del__(self):
Line 47:         shutil.rmtree(os.path.join(self.storage_repository, self.spUUID))
no need to join - self.storage_repository itself should be dropped, too.
Line 48: 
Line 49: 
Line 50: class SPM_MailMonitorTests(TestCaseBase):
Line 51:     def testThreadLeak(self):


--
To view, visit http://gerrit.ovirt.org/8980
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fd696a20254380e0a0067dd33c7709445e38afb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list