Change in vdsm[master]: Change in error message format

barumuga at redhat.com barumuga at redhat.com
Fri Nov 2 07:11:51 UTC 2012


Bala.FA has posted comments on this change.

Change subject: Change in error message format
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/gluster/exception.py
Line 56:         s = self.message
Line 57:         if m:
Line 58:             s += '\nerror: ' + m
Line 59:         if self.rc:
Line 60:             s += '\nreturn code: %s' % self.rc
As its base class, some of inherited class doesn't use rc and/or out and some class does.  To make it generic, default value of rc, out and err shows 'success' illusion in messages at engine side.

This fix just makes error message clear.   'return code: 0' or 'error:' doesn't make clarity to the user.
Line 61: 
Line 62:         return s
Line 63: 
Line 64:     def response(self):


--
To view, visit http://gerrit.ovirt.org/8689
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb948bb212ae866600aabad2190ff52f2cbc05bf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>


More information about the vdsm-patches mailing list