Change in vdsm[master]: Implement a zombie reaper

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Fri Nov 2 02:37:04 UTC 2012


Royce Lv has posted comments on this change.

Change subject: Implement a zombie reaper
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File vdsm/zombieReaper.py
Line 13: def _tryReap(pid):
Line 14:         try:
Line 15:             pid, rv = os.waitpid(pid, os.WNOHANG)
Line 16:             if pid != 0:
Line 17:                 _trackedPids.discard(pid)
Shall we add log here to see we actually reaped the pid?
Line 18:         except OSError:
Line 19:             _trackedPids.discard(pid)
Line 20: 
Line 21: 


Line 28:     signal.signal(signal.SIGCHLD, _zombieReaper)
Line 29: 
Line 30: 
Line 31: def unregisterSignalHandler():
Line 32:     signal.signal(signal.SIGCHLD, signal.SIG_DFL)
I'd like to recommend we use old_handler = getsignal(signal.SIGCHLD) on register, on unregister using signal.signal(signal.SIGCHILD, old_handler)


--
To view, visit http://gerrit.ovirt.org/8937
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fdf96e195135284b2733b21f611918ffbf69791
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Peter Portante <peter.portante at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list