Change in vdsm[master]: Make sure during upgrade that lease files have correct permi...
danken at redhat.com
danken at redhat.com
Thu Nov 1 20:37:38 UTC 2012
Dan Kenigsberg has posted comments on this change.
Change subject: Make sure during upgrade that lease files have correct permission
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
nits only. thanks.
....................................................
Commit Message
Line 3: AuthorDate: 2012-11-01 15:34:04 -0400
Line 4: Commit: Saggi Mizrahi <smizrahi at redhat.com>
Line 5: CommitDate: 2012-11-01 15:34:04 -0400
Line 6:
Line 7: Make sure during upgrade that lease files have correct permission
Commit message should refer to
https://bugzilla.redhat.com/show_bug.cgi?id=870024
I suppose. Please support future git-log'ers.
Line 8:
Line 9: Change-Id: I6e0a19ae3ea5b256850a4ef557ac14c5a1f660ef
....................................................
File vdsm/storage/fileSD.py
Line 127: raise se.StorageDomainMetadataNotFound(sdUUID, self.metafile)
Line 128: self.imageGarbageCollector()
Line 129: self._registerResourceNamespaces()
Line 130:
Line 131: def verifyLeaseFilePermissions(self):
name confusing: it does not check only the leases file
Line 132: procPool = oop.getProcessPool(self.sdUUID)
Line 133: for metaFile in (sd.LEASES, sd.IDS, sd.INBOX, sd.OUTBOX):
Line 134: try:
Line 135: fpath = os.path.join(self.getMDPath(), metaFile)
Line 135: fpath = os.path.join(self.getMDPath(), metaFile)
Line 136: procPool.os.chmod(fpath, 0660)
Line 137: except Exception, e:
Line 138: raise se.StorageDomainMetadataCreationError(
Line 139: "Lease permission change file '%s' failed: %s" % (metaFile, str(e)))
mentioning the long line would be nasty. but please avoid calling str() - it would explode if e has unicode inside. '%s' does the Right Thing.
Line 140:
Line 141: @classmethod
Line 142: def _prepareMetadata(cls, domPath, sdUUID, domainName, domClass,
Line 143: remotePath, storageType, version):
--
To view, visit http://gerrit.ovirt.org/8985
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e0a19ae3ea5b256850a4ef557ac14c5a1f660ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
More information about the vdsm-patches
mailing list