Change in vdsm[master]: Adding threads limitation to misc.tmap

ybronhei at redhat.com ybronhei at redhat.com
Thu Nov 1 14:06:21 UTC 2012


Yaniv Bronhaim has posted comments on this change.

Change subject: Adding threads limitation to misc.tmap
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File vdsm/storage/misc.py
Line 1097:     if maxthreads < 1 and maxthreads != UNLIMITED_THREADS:
Line 1098:         raise ValueError("Wrong input passed to function tmap: %s", maxthreads)
Line 1099: 
Line 1100:     resultsDict = {}
Line 1101:     tmap.error = None
You right! 
I can also create a namespace here... like:
tmapNS = namespace()
and use tmapNS.error to keep this variable's scope anytime you call this function. how is that sound? is it easier to understand the list thing than creating a namespace?
Line 1102: 
Line 1103:     def wrapper(f, arg, index):
Line 1104:         try:
Line 1105:             resultsDict[index] = f(arg)


--
To view, visit http://gerrit.ovirt.org/8858
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07845bfd78b9215e8994ac2ebe46a7ff78c85625
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list