Change in vdsm[master]: netinfo: added configuration to show dummy NIC's too

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Thu Nov 1 01:20:35 UTC 2012


Mark Wu has posted comments on this change.

Change subject: netinfo: added configuration to show dummy NIC's too
......................................................................


Patch Set 6: (1 inline comment)

Can anyone help me understand why we need show dummy nics in the nic list?  Thanks!

....................................................
File vdsm/netinfo.py
Line 43: LIBVIRT_NET_PREFIX = 'vdsm-'
Line 44: 
Line 45: 
Line 46: def _match_nic_name(nic, patterns):
Line 47:     return any(map(lambda p: fnmatch(nic, p), patterns))
is any(fnmatch.fnmatch(nic, p) for p in patterns)  better?
Line 48: 
Line 49: 
Line 50: def nics():
Line 51:     res = []


--
To view, visit http://gerrit.ovirt.org/8917
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica0ad974e6dd0d144a6bb0904fdcd6bbce99ff9f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hercinger Viktor <hercinger.viktor at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hercinger Viktor <hercinger.viktor at gmail.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list