Change in vdsm[master]: getAllVolumes() unit test.

danken at redhat.com danken at redhat.com
Wed May 30 19:29:15 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: getAllVolumes() unit test.
......................................................................


Patch Set 5: (1 inline comment)

/me tired.

....................................................
File tests/getAllVolumesTests.py
Line 72:             return eval(inp)
I dislike eval, and do not understand why you refuse to use a simple, readable, file-per-line content for glob_%s.out.

you are truly stiff-necked ;-)

--
To view, visit http://gerrit.ovirt.org/4592
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7cfb77f7675a58858507acf2b708317eb30a43d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list