Change in vdsm[master]: Adding "ksmShared" and "ksmSharing" statistics to getStats()

danken at redhat.com danken at redhat.com
Wed May 30 15:27:56 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Adding "ksmShared" and "ksmSharing" statistics to getStats()
......................................................................


Patch Set 6: I would prefer that you didn't submit this

ok, so _memShared(self) is broken.

Would you add this information to the commit message, explaining why it is broken? Maybe it could/should be fixed, instead of adding more "stuff" to the statistics?

Why do this in stages? I think you should discuss the added API in engine-devel before this is pushed into vdsm - maybe they need something completely different?

--
To view, visit http://gerrit.ovirt.org/4755
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8b5b366b8668cf74b04d1089e6e515e93c0f746
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list