Change in vdsm[master]: Close and remove the temporary file before raising a excepti...

danken at redhat.com danken at redhat.com
Wed May 30 10:47:30 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Close and remove the temporary file before raising a exception
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/multipath.py
Line 116:     supported state. The original configuration, if any, is saved
arghh, this whole function was born in sin. it should not be called by a running vdsm, only on installation (maybe as a vdsm-tool verb).

Line 121:     f.write(MPATH_CONF_TEMPLATE)
a more complete solution for this would be to use

 with tempfile.NamedTemporaryFile() as f:

--
To view, visit http://gerrit.ovirt.org/4885
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93eafbcf78805669596258b3579ee49cc1b79360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list