Change in vdsm[master]: Remove the effect of other parameters on configure_sysctl

danken at redhat.com danken at redhat.com
Wed May 30 10:38:47 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Remove the effect of other parameters on configure_sysctl
......................................................................


Patch Set 2: (2 inline comments)

Do we really want this code in Vdsm?
Why was /etc/sysctl.conf faulty to begin with?

....................................................
Commit Message
Line 11: than those of vdsm can't not configured corrcectly. So this
this sounds like someone else's bug - why should we worry about it in vdsm?

....................................................
File vdsm/vdsmd.init.in
Line 448:         [ "$ratio" == "5" ] && [ "$bg_ratio" == "2" ]
writing "5" twice seems like a bad idea (if someone ever wants to change it to 7, he should do it in two places).

--
To view, visit http://gerrit.ovirt.org/4865
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d9f917a4abfb6952fb9fdd6a9c0e12751ecd061
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list