Change in vdsm[master]: getDeviceList - passing includePartitioned to HSM

danken at redhat.com danken at redhat.com
Tue May 29 20:01:35 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: getDeviceList - passing includePartitioned to HSM
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File AUTHORS
Line 32:    Daniel Erez <derez at redhat.com>
Please keep sorted by last name (I see that we've failed to note Asir's and Li's misplacement. Please fix their position while at it).

....................................................
File vdsm_cli/vdsClient.py
Line 548:         storageType = int(args[0]) if len(args) > 0 else 0
0 happens to mean "all storage types" but that's undocumented. either fix

 getDeviceList(self, storageType=0, ...

or find a better solution (maybe in another patch).

Line 555:         except:
except: is frowned upon (ask Edu why). Why do you need it here?

 options['includePartitioned'] = options.get('includePartitioned'

seems enough to me.

--
To view, visit http://gerrit.ovirt.org/4828
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I388442f361ea4ae00e3d8878a2497c7819ab2214
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>


More information about the vdsm-patches mailing list